Text style editing: font/size/colour/alignment/bg/border/shadow in Inspector#166
Merged
Conversation
Wire the full text-style chain so selecting a text clip lets the user change font, size, color, alignment, background, border, and shadow in the Inspector, with the change re-rasterizing live. The domain `TextStyle` and the render `CosmicTextRasterizer` already supported these; the missing link was a command/IPC path to write `clip.text_style`, and a UI beyond the plain text box. - ops: add `text_style: Option<TextStyle>` to `ClipProperties`, written in `apply_property_changes` (reuses the existing `SetClipProperties` transaction → undo/redo/version for free). Two unit tests. - ipc: add `textStyle` to `ClipPropertiesDto` (camelCase, `serde(default)`) and map it through; serde regression test. - types: add `textStyle?: TextStyle` to `ClipPropertiesReq`. - inspector: TextTab gains font family / size (scrubbable) / color / alignment / background / border / shadow controls, reusing ScrubbableNumberField + the color-swatch pattern. New i18n keys (zh/en). - The `SetClipProperties` payload (ops enum + IPC DTO) is now boxed: `TextStyle` makes `ClipProperties` large enough to trip clippy's large_enum_variant, and the enum is cloned on every undo snapshot. Render needs no change: text resolves by clip_id and reads the live `text_style` at composite time. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wires text-clip style editing end-to-end: new
ClipProperties.text_style(domain→ops→IPC→editActions→Inspector TextTab), driving the existing CosmicTextRasterizer. Boxed the SetClipProperties payload to satisfy clippy large_enum_variant. New domain/ops/serde tests; web 174/174.🤖 Generated with Claude Code